Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements of the search mode #1658

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Improvements of the search mode #1658

merged 1 commit into from
Dec 17, 2024

Conversation

Yaraslaut
Copy link
Member

@Yaraslaut Yaraslaut commented Nov 26, 2024 •
edited
Loading

Fix bugs:

  • search string was not preserved when switching from search prompt into normal mode
  • when switching from insert into normal mode search string were not cleared

@github-actions github-actions bot added the VT: Backend Virtual Terminal Backend (libterminal API) label Nov 26, 2024
@Yaraslaut Yaraslaut added the no changelog Tells the CI to not require a changelog entry label Dec 5, 2024
@Yaraslaut Yaraslaut removed the no changelog Tells the CI to not require a changelog entry label Dec 5, 2024
@github-actions github-actions bot added the no changelog Tells the CI to not require a changelog entry label Dec 5, 2024
@Yaraslaut Yaraslaut marked this pull request as ready for review December 5, 2024 11:46
@Yaraslaut Yaraslaut force-pushed the improvement/search branch 2 times, most recently from 4035663 to 39b650f Compare December 12, 2024 13:32
@Yaraslaut Yaraslaut merged commit 46f74e9 into master Dec 17, 2024
30 checks passed
@Yaraslaut Yaraslaut deleted the improvement/search branch December 17, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart Awaiting requested review from christianparpart christianparpart is a code owner

Assignees
No one assigned
Labels
no changelog Tells the CI to not require a changelog entry VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Yaraslaut