fix a bug in the file contiki/core/sys/lc-switch.h #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the bug is in the line 65. the ';' should be removed, it is redundant and may cause problem.
|
what a problem you realy got? can you describe your situation? |
alexrayne
pushed a commit
to alexrayne/contiki
that referenced
this pull request
Nov 10, 2023
border-router.c: fix copyright year
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the bug is in the line 65. the ';' should be removed, it is redundant and may cause problem.
for example:
#define LC_INIT(s) s = 0;
#define PT_INIT(pt) LC_INIT((pt)->lc)
if we use PT_INIT just like it is use in the dhcpc.c file：
PT_INIT(&s.pt);
it is equal to :
s.pt->lc = 0**;;**
there will be two ';' in the code，so may be a problem sometimes in some conditions.
by the way , every version of contiki has this problem