fix: plain client method argument types for params with intersection types
#2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denkristoffer
approved these changes
Jan 6, 2025
|
@andipaetzold this annoyed me for a long time, thanks for fixing it :) |
t-col
approved these changes
Jan 8, 2025
|
🎉 This PR is included in version 11.40.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
paramsarguments of some plain client methodsDescription
The updated
OptionalDefaultstype introduced in #2491 causes issues for intersection types combined with union types.This makes some plain client methods unusable
The issue is that the builtin
Omitdoesn't play well with intersections. This PR replaces that with a union-compatibleOmit