.ci: Fix coveralls reports #469
Conversation
Coveralls needs its report to be performed against master branch to report properly the code coverage to Github. Signed-off-by: Sebastien Boeuf <[email protected]>
|
lgtm
|
There was a problem hiding this comment.
Given the little 'dance' we now do here, can we have a couple of comments in the script noting exactly what we are trying to achieve, as tbh what we had and what we have in the PR look similar enough to me in functionality that I think we could do with some precise clarification in the script itself.
Other than that - l g t m, believing you know exactly what you changed and why :-)
|
@grahamwhaley Coveralls is not properly reported because we are using origin/master instead of master. The name of the branch matters apparently and this should help our Coveralls reports to be recognized as the right ones |
|
@sboeuf - does that mean we also need to update: ... and could this maybe explain clearcontainers/jenkins#9? |
|
@jodh-intel Yes I think we should do the same for the script in tests repo, but I am not sure this explains the sporadic issue clearcontainers/jenkins#9 |
Coveralls needs its report to be performed against master branch to
report properly the code coverage to Github.
Signed-off-by: Sebastien Boeuf [email protected]