Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts,.github: add artifacts checking script, update issue template. #457

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Dec 18, 2024

Update github 'new release' issue template with instructions on how to check released Helm charts.

@klihub klihub force-pushed the devel/update-release-issue-template branch from f6fcc84 to a036e60 Compare December 18, 2024 09:24
Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we perhaps combine these lines with below lines in some runnable script ?

      for i in nri-resource-policy-topology-aware nri-resource-policy-balloons nri-resource-policy-template nri-config-manager nri-memory-qos nri-memtierd; do \
          skopeo inspect --format "$i: {{.Digest}}" docker://ghcr.io/containers/nri-plugins/$i:$VERSION;
      done

@klihub klihub changed the title .github: update new-release.md issue template. scripts,.github: add artifacts checking script, update new-release.md issue template. Dec 18, 2024
@klihub klihub force-pushed the devel/update-release-issue-template branch 2 times, most recently from 006e118 to bf85761 Compare December 18, 2024 17:23
@klihub
Copy link
Collaborator Author

klihub commented Dec 18, 2024

Can we perhaps combine these lines with below lines in some runnable script ?

Added a release artifacts checking scripts and referred to it from the updated issue template.

@klihub klihub force-pushed the devel/update-release-issue-template branch from 1580c10 to c19114f Compare December 18, 2024 17:26
@klihub klihub changed the title scripts,.github: add artifacts checking script, update new-release.md issue template. scripts,.github: add artifacts checking script, update issue template. Dec 18, 2024
@klihub klihub force-pushed the devel/update-release-issue-template branch from c19114f to 4311193 Compare December 18, 2024 17:28
@klihub klihub requested a review from fmuyassarov December 18, 2024 17:28
@klihub klihub force-pushed the devel/update-release-issue-template branch from 4311193 to 584306d Compare December 19, 2024 07:11
@klihub klihub requested a review from marquiz December 19, 2024 07:12
@klihub klihub force-pushed the devel/update-release-issue-template branch from 584306d to 1e263e0 Compare December 19, 2024 09:23
Add a scripts/release/check-artifacts.sh script for doing
release artifact verification.

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub force-pushed the devel/update-release-issue-template branch from 1e263e0 to 2ba040c Compare December 19, 2024 09:26
@klihub klihub requested a review from marquiz December 19, 2024 11:26
@klihub klihub force-pushed the devel/update-release-issue-template branch from 2ba040c to 49cbd21 Compare December 19, 2024 14:03
Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/ISSUE_TEMPLATE/new-release.md Outdated Show resolved Hide resolved
@klihub klihub force-pushed the devel/update-release-issue-template branch from 49cbd21 to f76a752 Compare December 19, 2024 16:23
@klihub klihub requested a review from fmuyassarov December 19, 2024 16:40
@klihub klihub force-pushed the devel/update-release-issue-template branch from f76a752 to c79ecb1 Compare December 20, 2024 08:01
@klihub klihub requested a review from kad December 20, 2024 08:22
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@askervin askervin merged commit f09cb0e into containers:main Dec 20, 2024
8 checks passed
@klihub klihub deleted the devel/update-release-issue-template branch December 20, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants