balloons: support for L2 cache cluster allocation #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on #383 |
askervin
force-pushed
the
5XX_balloons_cacheclusters
branch
3 times, most recently
from
745e5b1 to
d4c7412
Compare
askervin
changed the title
askervin
force-pushed
the
5XX_balloons_cacheclusters
branch
3 times, most recently
from
10357d5 to
cd8e43a
Compare
When two caches of the same level and kind share the same id, they collide in saved caches. This could lead to assigning cpu.caches caches from different package than the CPU itself. This change fixes the issue by ensuring unique cache ids to all caches of the same level and kind. Signed-off-by: Antti Kervinen <[email protected]>
Cache level functions, for instance CPU.GetCachesByLevel(), expect cpu.caches to be sorted by level, the lowest first. This change ensures that overridden caches follow this ordering, too, no matter in which order user has spesified them. Signed-off-by: Antti Kervinen <[email protected]>
This implementation expects CPUs sharing the same L2 cache also belonging into the same NUMA node, and that hyperthreads of the same CPU core always share L2 cache. Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
askervin
force-pushed
the
5XX_balloons_cacheclusters
branch
from
cd8e43a to
f9b7a24
Compare
Signed-off-by: Antti Kervinen <[email protected]>
|
(Documentation added as the last commit.) |
klihub
reviewed
Nov 19, 2024
Comment on lines
+29
to
+39
| {"cpusets": ["0-7", "8-15"], "level": 3, "size": "128M"}, | ||
|
|
||
| {"cpusets": ["0-1", "2-3", "4-5", "6-7"], "level": 2, "size": "4M", "kind": "u"}, | ||
| {"cpusets": ["8-9", "10-11", "12-13", "14-15"], "level": 2, "size": "4M", "kind": "u"}, | ||
|
|
||
| {"cpusets": ["0-1", "2-3", "4-5", "6-7"], "level": 1, "size": "256k", "kind": "d"}, | ||
| {"cpusets": ["0-1", "2-3", "4-5", "6-7"], "level": 1, "size": "128k", "kind": "i"}, | ||
|
|
||
| {"cpusets": ["8-9", "10-11", "12-13", "14-15"], "level": 1, "size": "256k", "kind": "d"}, | ||
| {"cpusets": ["8-9", "10-11", "12-13", "14-15"], "level": 1, "size": "128k", "kind": "i"} | ||
| ]''' |
There was a problem hiding this comment.
Is this cache configuration override interesting/useful ? Doesn't it provide the same grouping as the socket and the physical cores ?
klihub
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.