e2e: fix balloons test CPU frequencies #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use kHZ instead of MHz in minFreq and maxFreq as required in the real interface. Using wrong units in the tests did not fail because configuring CPU frequencies with any values does not really work in our test VMs. However, using wrong units in tests is misleading for anyone who tries to use similar configuration on bare metal. Signed-off-by: Antti Kervinen <[email protected]>
|
@askervin This is a bit late and only tangentially related, but having the unit be allowed in those configuration frequency values would allow the user to specify them in a human-friendly syntax and reduce the possibility for mistakes. If we don't do that, then using parameter names like minFreqkHz and maxFreqkHz would make the settings' unit self-documenting/obvious. |
Definitely something we should do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use kHZ instead of MHz in minFreq and maxFreq as required in the real interface. Using wrong units in the tests did not fail because configuring CPU frequencies with any values does not really work in our test VMs. However, using wrong units in tests is misleading for anyone who tries to use similar configuration on bare metal.