Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.3/#240] operator: ensure to kustomize operator manifests before local deployment #241

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

fmuyassarov
Copy link
Collaborator

Backport of #240

Ensure proper deployment by invoking copy-crds and kustomizations makefile targets alongside the deploy Makefile target. This change guarantees the presence of all necessary CRDs and ensures that kustomization files are appropriately modified before initiating the operator pod.

@fmuyassarov fmuyassarov changed the title [release-0.3/#240] operator: ensure CRDs are copied during the local deployment [release-0.3/#240] operator: ensure to kuztomize operator manifests before local deployment Jan 25, 2024
Ensure proper deployment by invoking copy-crds and kustomizations
makefile targets alongside the deploy Makefile target. This change
guarantees the presence of all necessary CRDs and ensures that
kustomization files are appropriately modified before initiating
the operator pod.

Signed-off-by: Feruzjon Muyassarov <[email protected]>
@fmuyassarov fmuyassarov force-pushed the fix-makefile-release-03 branch from 74d8a15 to 4f32177 Compare January 25, 2024 09:43
@fmuyassarov fmuyassarov requested review from klihub and marquiz January 25, 2024 15:25
Copy link
Collaborator

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but let's wait for #240)

Copy link
Collaborator

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor nitpick about commit/PR content vs. message/description.

@klihub klihub changed the title [release-0.3/#240] operator: ensure to kuztomize operator manifests before local deployment [release-0.3/#240] operator: ensure to kustomize operator manifests before local deployment Jan 25, 2024
@klihub klihub merged commit d3f3ac6 into containers:release-0.3 Jan 25, 2024
2 checks passed
@fmuyassarov fmuyassarov deleted the fix-makefile-release-03 branch January 25, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants