log: golangci-lint fixes.

Signed-off-by: Krisztian Litkey <[email protected]>

pkg/log/config.go

@@ -31,8 +31,6 @@ const (
 	debugEnvVar = "LOGGER_DEBUG"
 	// logSourceEnvVar is the environment variable used to seed source logging.
 	logSourceEnvVar = "LOGGER_LOG_SOURCE"
-	// configModule is our module name in the runtime configuration.
-	configModule = "logger"
 )
 
 // srcmap tracks debugging settings for sources.

pkg/log/klogcontrol/klogcontrol.go

@@ -18,7 +18,7 @@ import (
 	"errors"
 	"flag"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"os"
 	"strings"
 
@@ -69,7 +69,7 @@ func klogError(format string, args ...interface{}) error {
 
 // init discovers klog flags and sets up dynamic control for them.
 func init() {
-	ctl.SetOutput(ioutil.Discard)
+	ctl.SetOutput(io.Discard)
 	klog.InitFlags(ctl.FlagSet)
 	ctl.VisitAll(func(f *flag.Flag) {
 		if name, value, ok := getEnvForFlag(f.Name); ok {
@@ -84,7 +84,10 @@ func init() {
 			if f.Name == "skip_headers" {
 				if value, _ := os.LookupEnv("JOURNAL_STREAM"); value != "" {
 					klog.Infof("Logging to journald, forcing headers off...")
-					ctl.Set(f.Name, "true")
+					err := ctl.Set(f.Name, "true")
+					if err != nil {
+						klog.Warningf("failed to set klog flag %s to true: %v", f.Name, err)
+					}
 				}
 			}
 		}

pkg/log/log.go

@@ -161,7 +161,10 @@ func DebugEnabled(source string) bool {
 func SetLevel(level Level) {
 	log.Lock()
 	defer log.Unlock()
-	log.setLevel(level)
+	err := log.setLevel(level)
+	if err != nil {
+		Default().Warn("failed to set log level to %v: %v", level, err)
+	}
 }
 
 // Flush flushes any pending log messages.

pkg/log/signal.go

@@ -35,12 +35,7 @@ func SetupDebugToggleSignal(sig os.Signal) {
 	go func(sig <-chan os.Signal) {
 		state := map[bool]string{false: "off", true: "on"}
 		for {
-			select {
-			case _, ok := <-sig:
-				if !ok {
-					return
-				}
-			}
+			<-sig
 			log.forced = !log.forced
 			deflog.Warn("forced full debugging is now %s...", state[log.forced])
 		}