-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move windows CheckHostAndContainerCompat() function from hcsshim locally to platform repo itself Signed-off-by: Kirtana Ashok <[email protected]>
- Loading branch information
Showing
5 changed files
with
171 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| /* | ||
| Copyright The containerd Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package platforms | ||
|
|
||
| // osVersion is a wrapper for Windows version information | ||
| // https://msdn.microsoft.com/en-us/library/windows/desktop/ms724439(v=vs.85).aspx | ||
| type osVersion struct { | ||
| Version uint32 | ||
| MajorVersion uint8 | ||
| MinorVersion uint8 | ||
| Build uint16 | ||
| } | ||
|
|
||
| // Windows Client and Server build numbers. | ||
| // | ||
| // See: | ||
| // https://learn.microsoft.com/en-us/windows/release-health/release-information | ||
| // https://learn.microsoft.com/en-us/windows/release-health/windows-server-release-info | ||
| // https://learn.microsoft.com/en-us/windows/release-health/windows11-release-information | ||
| const ( | ||
| // RS5 (version 1809, codename "Redstone 5") corresponds to Windows Server | ||
| // 2019 (ltsc2019), and Windows 10 (October 2018 Update). | ||
| RS5 = 17763 | ||
|
|
||
| // V21H2Server corresponds to Windows Server 2022 (ltsc2022). | ||
| V21H2Server = 20348 | ||
|
|
||
| // LTSC2022 (Windows Server 2022) is an alias for [V21H2Server] | ||
| LTSC2022 = V21H2Server | ||
|
|
||
| // V22H2Win11 corresponds to Windows 11 (2022 Update). | ||
| V22H2Win11 = 22621 | ||
| ) | ||
|
|
||
| // List of stable ABI compliant ltsc releases | ||
| // Note: List must be sorted in ascending order | ||
| var compatLTSCReleases = []uint16{ | ||
| V21H2Server, | ||
| } | ||
|
|
||
| // CheckHostAndContainerCompat checks if given host and container | ||
| // OS versions are compatible. | ||
| // It includes support for stable ABI compliant versions as well. | ||
| // Every release after WS 2022 will support the previous ltsc | ||
| // container image. Stable ABI is in preview mode for windows 11 client. | ||
| // Refer: https://learn.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/version-compatibility?tabs=windows-server-2022%2Cwindows-10#windows-server-host-os-compatibility | ||
| func checkHostAndContainerCompat(host, ctr osVersion) bool { | ||
| // check major minor versions of host and guest | ||
| if host.MajorVersion != ctr.MajorVersion || | ||
| host.MinorVersion != ctr.MinorVersion { | ||
| return false | ||
| } | ||
|
|
||
| // If host is < WS 2022, exact version match is required | ||
| if host.Build < V21H2Server { | ||
| return host.Build == ctr.Build | ||
| } | ||
|
|
||
| var supportedLtscRelease uint16 | ||
| for i := len(compatLTSCReleases) - 1; i >= 0; i-- { | ||
| if host.Build >= compatLTSCReleases[i] { | ||
| supportedLtscRelease = compatLTSCReleases[i] | ||
| break | ||
| } | ||
| } | ||
| return ctr.Build >= supportedLtscRelease && ctr.Build <= host.Build | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| Copyright The containerd Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package platforms | ||
|
|
||
| import ( | ||
| "testing" | ||
| ) | ||
|
|
||
| // Test the platform compatibility of the different | ||
| // OS Versions considering two ltsc container image | ||
| // versions (ltsc2019, ltsc2022) | ||
| func Test_PlatformCompat(t *testing.T) { | ||
| for testName, tc := range map[string]struct { | ||
| hostOs uint16 | ||
| ctrOs uint16 | ||
| shouldRun bool | ||
| }{ | ||
| "RS5Host_ltsc2019": { | ||
| hostOs: RS5, | ||
| ctrOs: RS5, | ||
| shouldRun: true, | ||
| }, | ||
| "RS5Host_ltsc2022": { | ||
| hostOs: RS5, | ||
| ctrOs: V21H2Server, | ||
| shouldRun: false, | ||
| }, | ||
| "WS2022Host_ltsc2019": { | ||
| hostOs: V21H2Server, | ||
| ctrOs: RS5, | ||
| shouldRun: false, | ||
| }, | ||
| "WS2022Host_ltsc2022": { | ||
| hostOs: V21H2Server, | ||
| ctrOs: V21H2Server, | ||
| shouldRun: true, | ||
| }, | ||
| "Wind11Host_ltsc2019": { | ||
| hostOs: V22H2Win11, | ||
| ctrOs: RS5, | ||
| shouldRun: false, | ||
| }, | ||
| "Wind11Host_ltsc2022": { | ||
| hostOs: V22H2Win11, | ||
| ctrOs: V21H2Server, | ||
| shouldRun: true, | ||
| }, | ||
| } { | ||
| // Check if ltsc2019/ltsc2022 guest images are compatible on | ||
| // the given host OS versions | ||
| // | ||
| hostOSVersion := osVersion{ | ||
| MajorVersion: 10, | ||
| MinorVersion: 0, | ||
| Build: tc.hostOs, | ||
| } | ||
| ctrOSVersion := osVersion{ | ||
| MajorVersion: 10, | ||
| MinorVersion: 0, | ||
| Build: tc.ctrOs, | ||
| } | ||
| if checkHostAndContainerCompat(hostOSVersion, ctrOSVersion) != tc.shouldRun { | ||
| var expectedResultStr string | ||
| if !tc.shouldRun { | ||
| expectedResultStr = " NOT" | ||
| } | ||
| t.Fatalf("Failed %v: host %v should%s be able to run guest %v", testName, tc.hostOs, expectedResultStr, tc.ctrOs) | ||
| } | ||
| } | ||
| } |