Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vsize = 0 to overlaybd-create #286

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

liulanzheng
Copy link
Member

What this PR does / why we need it:

Add support for vsize = 0 to overlaybd-create indicating that the vsize is inherited from the lower layers.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

indicating that the vsize is inherited from the lower layers.

Signed-off-by: Lanzheng Liu <[email protected]>
@BigVan
Copy link
Member

BigVan commented Nov 10, 2023

LGTM
it seems the snapshotter should also be modified for this PR

@liulanzheng
Copy link
Member Author

@BigVan that may take some time

@liulanzheng liulanzheng merged commit 319597c into containerd:main Nov 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants