Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From reading code, it seems to me like:
XDGRuntimeDir()
should check the value ofROOTLESSKIT_PARENT_EUID
(likeParentEUID
does)getXDGRuntimeDir()
in bypass4netns is essentially duplicatingXDGRuntimeDir()
getRuntimeVariableDataDir
andCNIRuntimeDir
should not ignore errors, and they seem to have faulty logic (relying onGeteuid
regardless of conditions), or callingrootlessutil.ParentEUID
which will redo stuff done already inXDGRuntimeDir()
PR addresses these.