reset spec if update returned error #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AkihiroSuda could you please review this pr? thanks. |
|
How to test this? |
|
1、update memory and gave a wrong args to restart. nerdctl -n k8s.io update --memory=450000000 --restart=123 ef662、This will got an error like this: FATA[0000] 1 errors:
unsupported restart policy "123", supported policies are: ["no" "always" "on-failure" "unless-stopped"]3、 nerdctl -n k8s.io inspect --mode=native <Container ID>inspect we can see the memory is 450000000 now. In fact, the memory is not being updated. |
|
Can we have an integration test? |
|
Ok, I will do it. |
zzzzzzzzzy9
force-pushed
the
update
branch
2 times, most recently
from
dee98b2 to
a99bdc0
Compare
Signed-off-by: zzzzzzzzzy9 <[email protected]>
|
Done. @AkihiroSuda |
AkihiroSuda
reviewed
Jan 17, 2025
| ) | ||
|
|
||
| func TestUpdateContainer(t *testing.T) { | ||
| testutil.DockerIncompatible(t) |
There was a problem hiding this comment.
Because this depends on inspect --mode=native to see the memory change, but docker does not support inspect --mode=native
AkihiroSuda
approved these changes
Jan 20, 2025
|
We can't use exec because the update fails and the actual memory is not modified. But the original situation is that even though it has not been modified, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reset spec if update returned error