Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pip usage example with CS9 #726

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcapiitao
Copy link

CS8 is EOL since May 31 2024 [1], this patch updates the example of pip usage to use CS9.
Plus, we need to enable the CRB repository which provides gobject-introspection-devel.

[1] https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Docs updated (if applicable)
  • Docs links in the code are still valid (if docs were updated)

Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:

CS8 is EOL since May 31 2024 [1], this patch updates the
example of pip usage to use CS9.
Plus, we need to enable the CRB repository which provides
gobject-introspection-devel.

[1] https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/

# python3.9 runtime, C build dependencies
RUN dnf -y install 'dnf-command(config-manager)' && \
dnf config-manager --set-enabled crb && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: I didn't know we had an example like this until you pointed it out.

CS is a rolling distro which breaks package updates more often than not sadly (at least it used to be the case). I mean what you have here is all fine but strictly from docs POV I just wonder if it deserves the promotion (even just as an example) since it requires the Content Ready Builder repo to enable headers. Anyway, I think this hunk would be slightly simplified if you replaced CS with an example using AlmaLinux or Rocky where you don't need either the config manager or the CRB repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Atomic reactor uses Fedora, so we might as well just do the same.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants