Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cachi2 task #2121

Merged
Merged

Conversation

MartinBasti
Copy link
Contributor

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Python type annotations added to new code
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates
  • New feature can be disabled from a configuration file

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

tekton/tasks/binary-container-cachi2.yaml Fixed Show fixed Hide fixed
tekton/tasks/binary-container-cachi2.yaml Fixed Show fixed Hide fixed
tekton/tasks/binary-container-cachi2.yaml Fixed Show fixed Hide fixed
tekton/tasks/binary-container-cachi2.yaml Fixed Show fixed Hide fixed
tekton/tasks/binary-container-cachi2.yaml Fixed Show fixed Hide fixed
tekton/tasks/binary-container-cachi2.yaml Fixed Show fixed Hide fixed
tekton/tasks/binary-container-cachi2.yaml Fixed Show fixed Hide fixed
tekton/tasks/binary-container-cachi2.yaml Fixed Show fixed Hide fixed
tekton/tasks/binary-container-cachi2.yaml Fixed Show fixed Hide fixed
tekton/tasks/binary-container-cachi2.yaml Fixed Show fixed Hide fixed
@MartinBasti MartinBasti force-pushed the cachi2-init branch 5 times, most recently from 1afaa4d to 5adc72b Compare October 30, 2024 13:58
@MartinBasti MartinBasti force-pushed the cachi2-init branch 6 times, most recently from 96aa1c5 to 1099a24 Compare November 6, 2024 10:28
@MartinBasti MartinBasti marked this pull request as ready for review November 6, 2024 10:31
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable 👍

atomic_reactor/cli/task.py Show resolved Hide resolved
atomic_reactor/plugins/cachi2_init.py Show resolved Hide resolved
tekton/tasks/binary-container-cachi2.yaml Outdated Show resolved Hide resolved
Add init task/step responsible for creating directory structure,
cloning remote sources and preparing options file for cachi2 run.

Signed-off-by: Martin Basti <[email protected]>
Shellcheck for tekton github action

Signed-off-by: Martin Basti <[email protected]>
Add cachi2 step that:
- fetches deps
- create env file and env json
- make source archives
- remove git (option to keep git will be added later)
- merge sboms into single one

Signed-off-by: Martin Basti <[email protected]>
Fixing format of envvars, Cachi2 have slightly different format

Signed-off-by: Martin Basti <[email protected]>
Postprocssing plugin to take cachi2 generated dependencies and generate
expected metadata for OSBS and prepare sources into build dirs.

Signed-off-by: Martin Basti <[email protected]>
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just do not merge the DO NOT MERGE commit 😄

use reflink to copy sources into build dir to save space

Signed-off-by: Martin Basti <[email protected]>
@MartinBasti
Copy link
Contributor Author

Rebased and removed DO NOT MERGE commit

@MartinBasti MartinBasti merged commit 9676c4a into containerbuildsystem:feature_cachi2 Nov 8, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants