cachi2: generate remote-source.json #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmeliik
reviewed
Aug 20, 2024
MartinBasti
force-pushed
the
cachi2-generate-request.json
branch
from
87cf205
to
1b73052
Compare
MartinBasti
commented
Aug 21, 2024
atomic_reactor/utils/cachi2.py
Outdated
| "replaces": None, # it's always None, replacements aren't supported by cachi2 | ||
| "type": heuristic_type, | ||
| "version": version, | ||
| # "dev": True # TODO |
There was a problem hiding this comment.
@chmeliik can we somehow determine this?
There was a problem hiding this comment.
For npm packages (and maybe yarn in the future) yes, from the cdx:npm:package:development property
For others no
MartinBasti
force-pushed
the
cachi2-generate-request.json
branch
3 times, most recently
from
ba61dea
to
20da732
Compare
Cachi2 doesn't provide remote-source.json but for backward compatibility OSBS must provide it. STONEBLD-2585 Signed-off-by: Martin Basti <[email protected]>
MartinBasti
force-pushed
the
cachi2-generate-request.json
branch
from
20da732
to
7732d9c
Compare
mkosiarc
approved these changes
Aug 27, 2024
|
LGTM, in ideal world we could use more abstraction by exporting some functionality to individual helper functions so they could be read and understood better (for example, the type matching or version finding). But I am not expecting any change here. |
chmeliik
approved these changes
Aug 27, 2024
|
I appreciate the comments, without them I would be completely lost. |
MartinBasti
merged commit 7870665
into
containerbuildsystem:feature_cachi2
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cachi2 doesn't provide remote-source.json but for backward compatibility OSBS must provide it.
STONEBLD-2585
Maintainers will complete the following section