new pipelines 1.13 changes #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcerven
changed the title
chmeliik
approved these changes
Feb 28, 2024
rcerven
changed the title
rcerven
changed the title
rcerven
force-pushed
the
pipelines13
branch
4 times, most recently
from
a4afbb3
to
b5e3a57
Compare
mkosiarc
approved these changes
Mar 4, 2024
chmeliik
reviewed
Mar 4, 2024
Comment on lines
-113
to
+114
| build_host = self._get_hostname_for_platform(platform) | ||
| build_host = json.loads(self._get_hostname_for_platform(platform)) |
There was a problem hiding this comment.
Why is this change needed?
There was a problem hiding this comment.
all in results are json dumps, this one is string and it wasn't needed before, so something changed with results storing string in tekton
* STONEBLD-2192 Signed-off-by: Robert Cerven <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainers will complete the following section