Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force podman-remote to use Dockerfile, #2086

Merged
merged 1 commit into from
Nov 8, 2023
Merged

force podman-remote to use Dockerfile, #2086

merged 1 commit into from
Nov 8, 2023

Conversation

rcerven
Copy link
Member

@rcerven rcerven commented Nov 7, 2023 •
edited by chmeliik
Loading

because in case Containerfile exists as well, it will use that instead

  • STONEBLD-1929

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • n/a Python type annotations added to new code
  • n/a JSON/YAML configuration changes are updated in the relevant schema
  • n/a Changes to metadata also update the documentation for the metadata
  • n/a Pull request has a link to an osbs-docs PR for user documentation updates
  • n/a New feature can be disabled from a configuration file

@rcerven
force podman-remote to use Dockerfile,
8aa34fc 
because in case Containerfile exists as well, it will use that instead

* STONEBLD-1929

Signed-off-by: Robert Cerven <[email protected]>
@rcerven rcerven changed the title for podman-remote to use Dockerfile, force podman-remote to use Dockerfile, Nov 7, 2023
@chmeliik
Copy link
Contributor

chmeliik commented Nov 8, 2023

The failing CI is expected?

@mkosiarc
Copy link
Contributor

mkosiarc commented Nov 8, 2023

LGTM except the failing CI

chmeliik
chmeliik approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's fix the CI some other time

@rcerven rcerven merged commit 14c34f7 into containerbuildsystem:master Nov 8, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmeliik chmeliik chmeliik approved these changes

@mkosiarc mkosiarc mkosiarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcerven @chmeliik @mkosiarc