React Cinema Project #20
Open
+1,121
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrigrabov
reviewed
Oct 4, 2018
src/components/App.js
Outdated
| this.setState({movieresults: content.Search, moviestotal: content.totalResults}) | ||
| } | ||
| else { | ||
| this.setState({noresults: "empty"}); |
There was a problem hiding this comment.
It might better to set {movieresults: []}. Then you can check the length of the array to make sure you have movies to display. Saves you having to use an additional property in state
dmitrigrabov
reviewed
Oct 4, 2018
| receiveResults() { | ||
| this.setState({noresults: noresults}) | ||
| } | ||
| receiveMovies() { |
There was a problem hiding this comment.
It looks like this method does not get called from anywhere
dmitrigrabov
reviewed
Oct 4, 2018
src/components/Preview.js
Outdated
| @@ -0,0 +1,16 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
It looks like this component is not in use and can be removed
dmitrigrabov
reviewed
Oct 4, 2018
src/components/Search.js
Outdated
| <section className="search"> | ||
| <form onSubmit={this.handleSubmit} className="search__form" id="search"> | ||
| <div className="search__input-wrapper"> | ||
| <input onChange={this.handleChange} className={searchInput} type='text' name="search" placeholder="Enter film title" autoComplete="search" value={this.props.query} /> |
There was a problem hiding this comment.
Nice. Great to see query being used from props
|
Great work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I forgot to submit a pull request to my weekend project - apologies.