added css phoebedg #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrigrabov
reviewed
Jul 1, 2018
|
|
||
| this.state = { | ||
| movies: [], | ||
| moreInfo: [] |
There was a problem hiding this comment.
It might make sense to initialise moreInfo to empty string if it will store a string
dmitrigrabov
reviewed
Jul 1, 2018
| movies={this.state.movies} | ||
| getMoreInfo={this.getMoreInfo} | ||
| /> | ||
| {this.state.moreInfo === "" ? null : ( |
There was a problem hiding this comment.
this might not work since moreInfo is initialised to empty array. You could also simplify it to take advantage of empty string being falsy by writing it as !this.state.moreInfo ? null : <Info moreInfo={this.state.moreInfo} />
dmitrigrabov
reviewed
Jul 1, 2018
| @@ -0,0 +1,20 @@ | |||
| import React from "react"; | |||
|
|
|||
| function Info({ moreInfo }) { | |||
dmitrigrabov
reviewed
Jul 1, 2018
| import React from "react"; | ||
|
|
||
| function Info({ moreInfo }) { | ||
| console.log("moreInfo:", moreInfo); |
There was a problem hiding this comment.
Minor point: it's good practice to avoid committing console.logs
dmitrigrabov
reviewed
Jul 1, 2018
| @@ -0,0 +1,76 @@ | |||
| import React from "react"; | |||
|
|
|||
| const config = { | |||
dmitrigrabov
reviewed
Jul 1, 2018
| box-shadow: 5px 1px 1px red; | ||
| } | ||
|
|
||
| .movieheading { |
There was a problem hiding this comment.
kebab case works well for multi-word CSS classes. For example .card-text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.