David Gridley React Cinema #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to local storage
dmitrigrabov
reviewed
Oct 3, 2018
| } | ||
|
|
||
| receiveFavouritesInfo(id, favourite) { | ||
| if ( |
There was a problem hiding this comment.
The logic in this function could be simplified. If you calculate the new favourites array for each condition and store in a variable, you can then set it in state and local storage after. It will save you having to repeat setState and localStorage.setItem
dmitrigrabov
reviewed
Oct 3, 2018
|
|
||
| receiveFavouritesInfo(id, favourite) { | ||
| if ( | ||
| id === "add__to__favourites" && |
There was a problem hiding this comment.
I'd also say moving favourites up and down should be broken out into own functions to keep them shorter
dmitrigrabov
reviewed
Oct 3, 2018
|
|
||
| render() { | ||
| return ( | ||
| <header className="header"> |
|
Good work. However the logic around favourites handling could be tidied up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.