Luke Sikuade Project Cinema #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,48 +1,20 @@ | |||
| # Project Cinema | |||
| ## Cinema App | |||
| }); | ||
|
|
||
| const refineUrl = search => { | ||
| let pageNum = 1; |
There was a problem hiding this comment.
Wouldn't pageNum be reset to 1 every time this function is called this making pageNum++ redundant
|
|
||
| const header = document.querySelector("header"); | ||
| header.appendChild(next); | ||
| next.addEventListener("click", function(event) { |
There was a problem hiding this comment.
It would better to implement the click handler using delegation to avoid having to reset it each time function is called
| const review = await getReview(movieID); | ||
| //Currently not operating as intended. | ||
| let mobileClose = ""; | ||
| screen.width < 700 ? (mobileClose = "Close") : (mobileClose = "x"); |
There was a problem hiding this comment.
This could better written as const mobileClose = screen.width < 700 ? "Close" : "x". A ternary is an expression and returns a value which we can assign to output variable
| const movieData = await response.json(); | ||
|
|
||
| const movie = movieData.results.find(item => { | ||
| if (item.title === filmObject.Title) { |
There was a problem hiding this comment.
Since find callback expects a boolean, this could be simplified to return item.title === filmObject.Title
| } | ||
| } | ||
|
|
||
| // function youMayAlsoLike(genre, actors, director, writer){ |
There was a problem hiding this comment.
Commented out code can removed to avoid clutter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.