Project cinema from Yel #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he search results
| ## README.md | ||
|
|
||
| When finished, include a README.md in your repo. Someone who is not familiar with the project should be able to look at it and understand what it is and what to do with it. Explain functionality created, mention any outstanding issues and possible features you would include if you had more time. List technologies used to create the app. Include a screenshot of your app in the README. | ||
| Background: |
|
|
||
|
|
||
| //fetches movies from API - search by names | ||
| function getMoviesByName(movieName) { |
| } | ||
|
|
||
| function saveDiv(){ | ||
| let savedDiv = JSON.stringify(document.querySelector('.favourites__divs').innerHTML); |
There was a problem hiding this comment.
It would be better to store data in localStorage rather than the entire HTML. We want to generate the HTML based on the stored data
| max-width: 800px; | ||
| } */ | ||
|
|
||
| .poster { |
There was a problem hiding this comment.
Would have been great to see BEM in use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.