Lemony Responsive Cinema #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <link rel="stylesheet" href="styles/styles.css"> | ||
| </head> | ||
| <body> | ||
| <header class="mainheader"> |
| return item.Poster !== "N/A" | ||
| }); | ||
|
|
||
| searchArray.map(item => { |
There was a problem hiding this comment.
forEach would be better here since we don't use the returned value
| } | ||
|
|
||
|
|
||
| // function displayFullFilm(body) { |
There was a problem hiding this comment.
Commented out code can be removed to avoid clutter
| const searchText = form.search.value; | ||
| console.log(form.search.value); | ||
| // const searchQuery = formRef.search.value; | ||
| const APIQuery = `http://www.omdbapi.com/?s=${searchText}&page=${page}&apikey=eabbbb71`; |
There was a problem hiding this comment.
lower case variable name would be more appropriate
|
Good work. README would be great next time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run out of time to create a Readme - TODO
Stretch - paging only