Delivereat app #5
Conversation
| function getOrders() { | ||
| let orders = {}; | ||
|
|
||
| return { |
| }, | ||
|
|
||
| showDish() { | ||
| // return menu; |
There was a problem hiding this comment.
Unused code can be removed
|
|
||
|
|
||
| return { | ||
| showMenu() { |
There was a problem hiding this comment.
Minor naming point. It would be slightly clearer to name this method getMenu as it returns the menu. showMenu potentially implies some display logic
| addOrders(order); | ||
| res.json(showOrders()) | ||
| } else { | ||
| res.status(404).json({ error: "Order error" }); |
There was a problem hiding this comment.
404 generally refers to an missing resource on the server. Here you are checking that an order was sent up. If that is not the case something like 400, meaning Bad Request would be better
| res.render('index'); | ||
| }); | ||
|
|
||
| // Server stuff |
There was a problem hiding this comment.
Code is no longer in use and can be removed
| }); | ||
| } | ||
| ordersHandler(dishId, quantity, price, action) { | ||
| // Find if dish is already in orders and get position |
| const { date, totalAmount, products, menu, order, receiverDeletedOrder } = props; | ||
|
|
||
| const reorderHandler = () => { | ||
| const date = new Date(); |
There was a problem hiding this comment.
It would be great to move date formatting function to an external module. Let me know if you need help with this
| <div className="menu-wrapper"> | ||
| <Link to="/menu"><h5 className="menu__back-to-menu">Back to Menu</h5></Link> | ||
| <h1 className="menu__heading">Order History</h1> | ||
| <div className={"old-orders__empty " + (Object.keys(props.oldOrders).length > 0 ? "hidden" : "")}> |
There was a problem hiding this comment.
The condition could be written a little shorter using Object.keys(props.oldOrders).length since it will evaluate to true when length is greater than 0
| super(props); | ||
| this.state = { | ||
| menu: {}, | ||
| deliveryPrice: 2.50 |
There was a problem hiding this comment.
Since delivery price does not change is can go into a variable rather than be in state. For example put it on line 3 as const DELIVERY_PRICE = 2.50
|
|
||
| function checkoutHandler(order) { | ||
| const date = new Date(); | ||
| const minutes = date.getMinutes() < 10 ? '0' + date.getMinutes() : '' + date.getMinutes(); |
There was a problem hiding this comment.
Moving date formating to own module would allow you to re-use the code here and avoid duplication
| function BasketEmpty(props) { | ||
| return ( | ||
| <div id="basket__empty" | ||
| className={"basket__empty " + (Object.keys(props.orders).length === 0 ? '' : 'disabled')}> |
There was a problem hiding this comment.
Condition could be written as slightly shorter as !Object.keys(props.orders).length
|
|
||
| function BasketOrderSent(props) { | ||
| return ( | ||
| <div className={"basket-order__sent " + (props.orderSent === true ? '' : 'hidden')}> |
There was a problem hiding this comment.
Ternary could be slightly shorter using (props.orderSent ? '' : 'hidden'), since it will already check if the value is true
| function BasketPriceDisplay(props) { | ||
| return ( | ||
| <div className={"basket__checkout-button_wrapper " + (Object.keys(props.orders).length > 0 ? '' : 'hidden')}> | ||
| <div>Order: <strong>{props.orderAmount.toLocaleString('en-gb', { style: 'currency', currency: 'GBP' })}</strong></div> |
No description provided.