Kate's deliverEat #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .map(eachOrder => eachOrder.price * eachOrder.number) | ||
| .reduce((acc, item) => acc + item); | ||
| const deliveryCost = foodCost * 0.1; | ||
| const totalCost = foodCost * 1.1; |
There was a problem hiding this comment.
I would be better to use totalCost = foodCost + deliveryCost to prevent logic duplication
| @@ -0,0 +1,93 @@ | |||
| function database() { | |||
| placedOrders: body | ||
| }, | ||
| () => | ||
| localStorage.setItem( |
There was a problem hiding this comment.
Since placedOrders are stored on the server, I would suggest not storing them locally as well. Otherwise we end up with 2 sources of truth. It would better to fetch the data from the server when needed
| return item; | ||
| } | ||
| }) | ||
| .filter(item => item.number !== 0) |
| menu: [], | ||
| order: [], | ||
| placedOrders: [], | ||
| orderBasket: [], |
There was a problem hiding this comment.
it looks like orderBasket is not used and can probably be removed
|
Great work. I would suggest not using localStorage to store data which is also stored on server to avoid duplication. Just store everything on server and get it from there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.