fix: improve Gas Fee Estimation by Integrating Filecoin's EIP-1559-Compatible APIs #1182
Conversation
karlem
changed the title
karlem
changed the title
|
|
||
| *tx = TypedTransaction::Eip1559(tx_req); | ||
| } else { | ||
| return Err(Eip1559GasEstimatorError::failed_to_estimate_gas_not_supported()); |
There was a problem hiding this comment.
why not just skip the error so that other types of txns can go through so that it's more general. Or the purpose is only supporting EIP1559?
There was a problem hiding this comment.
Or the purpose is only supporting EIP1559?
Yes. As these endpoints are only available from EIP1559 upgrade.
|
|
||
| // Set the gas fees directly on the transaction. | ||
| let tx_req = inner | ||
| .clone() |
There was a problem hiding this comment.
why need to clone here instead of directly assign?
|
|
||
| // Delegate to the inner middleware for filling remaining transaction fields. | ||
| self.inner() | ||
| .fill_transaction(tx, block) |
There was a problem hiding this comment.
will the gas be overwritten by inner fill transaction? Will call inner first then overwrite the gas params be safer?
There was a problem hiding this comment.
I think - from what I have seen, the gas parameter is only set internally when it's not defined. But we define it here.
|
|
||
| // Proceed to send the transaction with the inner middleware. | ||
| self.inner() | ||
| .send_transaction(tx, block) |
There was a problem hiding this comment.
same question here, the inner will not overwrite the gas params updated right?
There was a problem hiding this comment.
Nope it should not. Answer above.👆🏻
Close #1175
Close #982
This PR updates our gas fee estimation to leverage the
eth_maxPriorityFeePerGasandeth_getBlockByNumber(to retrieve the currentbase_fee_per_gasfrom the latest mined block) API calls, using Eth-standard APIs available through Filecoin. Since Filecoin supports EIP-1559, these calls are fully compatible with Filecoin's implementation, aligning with standard EVM practices and ensuring interoperability across EVM chains.Key Changes:
max_priority_fee_per_gas()andbase_fee_per_gas()functions retrieve gas fee estimates based on Filecoin's adherence to EIP-1559.This approach simplifies our fee estimation logic by utilizing available EIP-1559-compatible APIs, improving chances of capturing better gas market dynamics on specific networks (Filecoin in this case) to increase chance of fast transaction inclusion within a block.