fix: improve Gas Fee Estimation by Integrating Filecoin's EIP-1559-Compatible APIs #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlem
changed the title
karlem
changed the title
|
|
||
| *tx = TypedTransaction::Eip1559(tx_req); | ||
| } else { | ||
| return Err(Eip1559GasEstimatorError::failed_to_estimate_gas_not_supported()); |
There was a problem hiding this comment.
why not just skip the error so that other types of txns can go through so that it's more general. Or the purpose is only supporting EIP1559?
|
|
||
| // Set the gas fees directly on the transaction. | ||
| let tx_req = inner | ||
| .clone() |
There was a problem hiding this comment.
why need to clone here instead of directly assign?
|
|
||
| // Delegate to the inner middleware for filling remaining transaction fields. | ||
| self.inner() | ||
| .fill_transaction(tx, block) |
There was a problem hiding this comment.
will the gas be overwritten by inner fill transaction? Will call inner first then overwrite the gas params be safer?
|
|
||
| // Proceed to send the transaction with the inner middleware. | ||
| self.inner() | ||
| .send_transaction(tx, block) |
There was a problem hiding this comment.
same question here, the inner will not overwrite the gas params updated right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1175
Close #982
This PR updates our gas fee estimation to leverage the
eth_maxPriorityFeePerGasandeth_getBlockByNumber(to retrieve the currentbase_fee_per_gasfrom the latest mined block) API calls, using Eth-standard APIs available through Filecoin. Since Filecoin supports EIP-1559, these calls are fully compatible with Filecoin's implementation, aligning with standard EVM practices and ensuring interoperability across EVM chains.Key Changes:
max_priority_fee_per_gas()andbase_fee_per_gas()functions retrieve gas fee estimates based on Filecoin's adherence to EIP-1559.This approach simplifies our fee estimation logic by utilizing available EIP-1559-compatible APIs, improving chances of capturing better gas market dynamics on specific networks (Filecoin in this case) to increase chance of fast transaction inclusion within a block.