Skip to content

Commit

Permalink
Merge pull request gjedeer#117 from jdufresne/persis
Browse files Browse the repository at this point in the history
Remove unused Celery::__construct() argument $persistent_messages
  • Loading branch information
gjedeer authored Jul 20, 2018
2 parents 6bc226c + b1a7025 commit 64e67a7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@
videlalvaro/php-amqplib is abandoned.
- Fix crash with the ampqlib backend when Celery has not yet created the
results exchange.
- The `Celery` constructor no longer accepts the argument
`persistent_messages`. It was previously unused.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ options:
'CN_match' => 'CERT_COMMON_NAME'
];

$c = new \Celery\Celery($host, $user, $password, $vhost, 'celery', 'celery', 5671, false, false, 0, $ssl_options);
$c = new \Celery\Celery($host, $user, $password, $vhost, 'celery', 'celery', 5671, false, 0, $ssl_options);

## CONNECTING TO REDIS

Expand Down
4 changes: 1 addition & 3 deletions src/Celery.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,10 @@ class Celery extends CeleryAbstract
* @param string binding AMQP binding a.k.a. routing key. See CELERY_DEFAULT_ROUTING_KEY. (set to 'celery' when in doubt)
* @param int port
* @param string connector Which connector library to use. One of: 'pecl', 'php-amqplib', 'php-amqplib-ssl', 'redis'
* @param bool persistent_messages False = transient queue, True = persistent queue. Check "Using Transient Queues" in Celery docs (set to false when in doubt)
* @param int result_expire Expire time for result queue, milliseconds (for AMQP exchanges only)
* @param array ssl_options Used only for 'php-amqplib-ssl' connections, an associative array with values as defined here: http://php.net/manual/en/context.ssl.php
*/

public function __construct($host, $login, $password, $vhost, $exchange='celery', $binding='celery', $port=5672, $connector=false, $persistent_messages=false, $result_expire=0, $ssl_options=[])
public function __construct($host, $login, $password, $vhost, $exchange='celery', $binding='celery', $port=5672, $connector=false, $result_expire=0, $ssl_options=[])
{
$broker_connection = [
'host' => $host,
Expand Down

0 comments on commit 64e67a7

Please sign in to comment.