950 implement function returing just the list of subjects #960
+153
−135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
GET /schemas
listing all schemas and metadata.:getSubjects(registryOrEnvironmentId, forceDeepFetch)
which drives theGET /subjects
"list subjects" route to only get the subject names from a schema registry, a route implemented by WarpStream. Implemented in base ResourceLoader w/o any caching. Future branch will implement caching layer inCCloudResourceLoader
.LocalResourceLoader.getTopicsForCluster()
andDirectResourceLoader.getTopicsForCluster()
into single concrete implementation withinResourceLoader
, which previously only had the abstract prototype.CCloudResourceLoader.getTopicsForCluster()
to downcall intoResourceLoader.getTopicsForCluster()
for the actual deep fetching + topic+subject correlating functionality. TheCCloudResourceLoader
implementation is freed to focus more specifically on the cache lookup and return or deep fetch + cache set concerns.correlateTopicsWithSchemaSubjects()
and its now single callerResourceLoader.getTopicsForCluster()
to operate in terms of the schema subject strings as fromgetSubjects()
instead of against whole Schema objects.Any additional details or context that should be provided?
ResourceLoader.getTopicsForCluster()
. TheCCloudResourceLoader
implementation of that method then ends up caching the resulting list ofKafkaTopic
models, so we're about as efficient as before.EnvironmentId
type. Proved useful in makinggetSubjects()
be able to internally handle if passed either an environment ID or a whole SchemaRegistry to operate against.createTestTopicData()
function from single test suite to reusable utility module, per its desire to be reusable when needed. Now used when testingcorrelateTopicsWithSchemaSubjects()
andResourceLoader.getTopicsForCluster()
(new test coming up Monday morning).Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Other
.vsix
file?