Deploy to Vercel with mocks #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hashedone
previously approved these changes
Oct 10, 2024
.env.sample
Outdated
Comment on lines
2
to
3
| #Optional | ||
| #NEXT_PUBLIC_MOCK_API=TRUE |
There was a problem hiding this comment.
Do we really need this kind of comments left out? Just remove it, if we want this constant we can add it. And if we want it configurable then we should make a way to configure it I think...
There was a problem hiding this comment.
Sure, I'll remove the comments but keep the variables there. This file is only used to easily generate a .env.local by copying it
Merged
abefernan
force-pushed
the
vercel-deploy
branch
from
c40213d to
4820f0a
Compare
abefernan
force-pushed
the
vercel-deploy
branch
from
72c87a6 to
099616f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.