-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before approve I want to double check if I understand this correctly. You moved from generic typescript any
assuming the received span data is a Json type as you expected to some zod
crate which allows you to operate on typed Json validated against a schema, right?
Exactly, it runtime checks that what we get from the API is what we want, that way. It also transforms the received data, so for example we can check the parent span with the https://github.com/confio/cosmwasm-tracing-ui/blob/type-traces/types/txs.ts#L28-L32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7df2983
to
797d173
Compare
797d173
to
357a589
Compare
Closes #5.
The wip rendering of the tags also shows now as a map, since we use that type for that field now: