Integration test #52
Integration test #52
Conversation
lmilleri
force-pushed
the
integration-test
branch
3 times, most recently
from
8a7984c
to
5eac361
Compare
|
PR reshaped to use the kuttl plugin, please review |
|
Can you make this run on Github? |
README.md
Outdated
|
|
||
| An attestation with the sample-attester is performed in an ephemeral kind cluster | ||
| Pre-requirements: | ||
| - k8s kuttl plugin installed |
There was a problem hiding this comment.
Please add a link to how to do this.
| @@ -0,0 +1,3 @@ | |||
| #!/bin/bash | |||
|
|
|||
| oc create secret generic kbsres1 --from-literal key1=res1val1 --from-literal key2=res1val2 -n trustee-operator-system | |||
Makefile
Outdated
| # pre-requirements: k8s kuttl plugin installed | ||
| # you can change the trustee image by defining the env variable KBS_IMAGE_NAME | ||
| # Usage: REGISTRY=<user-registry> KBS_IMAGE_NAME=<trustee-image> make e2e-test | ||
| .PHONY: e2e-test |
lmilleri
force-pushed
the
integration-test
branch
from
5eac361
to
4363d1a
Compare
lmilleri
force-pushed
the
integration-test
branch
from
4363d1a
to
27d4da4
Compare
|
Addressed comments and added github action. |
| @@ -0,0 +1,21 @@ | |||
| #!/bin/bash | |||
|
|
|||
| KBS_IMAGE_NAME="${KBS_IMAGE_NAME:-quay.io/confidential-containers/trustee:290fd0eb64ab20f50efbd27cf80542851c0ee17f}" | |||
There was a problem hiding this comment.
Remove the default value for this variable, we want the test to fail if it's not set.
There was a problem hiding this comment.
We'd need both the trustee and the client images to be specified and they are mandatory for the test to execute. I'll do the changes for the client image customization.
I think the default images have to be provided somehow, otherwise the github action won't be able to execute properly. Where do you reckon these images should be hardcoded?
- github action: ok for CI but if you run
make test-e2ethe images must be provided in the command - Makefile: both CI and
make test-e2eare ok
lmilleri
force-pushed
the
integration-test
branch
from
27d4da4
to
27c14a1
Compare
Run an e2e test with ephemeral kind cluster. Usage: make test-e2e The integration test is also executed as a github action Signed-off-by: Leonardo Milleri <[email protected]>
lmilleri
force-pushed
the
integration-test
branch
from
27c14a1
to
a8a6bf6
Compare
Run an e2e test with the sample attester in an ephemeral kind cluster.
This test requires the k8s kuttl plugin and kind installation when executed in local (e.g. make test-e2e).
Also added github action for executing the test on PR and merge in the main branch