Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix the CoCoKeyprovider image pushing logic #673

Merged

Conversation

Xynnn007
Copy link
Member

As the original repo is now archived, thus we havenot been able to publish the coco keyprovider image for a long time. This commit fixes this issue by changing the image repo.

Fixes #672

@mythi
Copy link
Contributor

mythi commented Aug 15, 2024

Good timing with the PR as I was just looking at this file and noticed that this is missing permissions.

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as part of fixing, add permissions to protect GITHUB_TOKEN

As the original  repo is now archived, thus we havenot been able to
publish the coco keyprovider image for a long time. This commit fixes
this issue by changing the image repo.

Fixes confidential-containers#672

Signed-off-by: Xynnn007 <[email protected]>
@Xynnn007 Xynnn007 force-pushed the fix-coco-keyprovider-release branch from cc8c316 to 7f03a91 Compare August 16, 2024 08:02
@Xynnn007 Xynnn007 requested a review from mythi August 16, 2024 08:03
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xynnn007 Xynnn007 merged commit 909fe14 into confidential-containers:main Aug 17, 2024
6 checks passed
@Xynnn007 Xynnn007 deleted the fix-coco-keyprovider-release branch August 18, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CoCoKeyprovider | Failed to publish image
4 participants