AA: Support CoCo-AS Attestation Token #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiale Zhang <[email protected]>
Signed-off-by: Jiale Zhang <[email protected]>
Signed-off-by: Jiale Zhang <[email protected]>
Xynnn007
reviewed
Jan 19, 2024
| use std::path::Path; | ||
| use std::sync::OnceLock; | ||
| use tokio::fs; | ||
|
|
||
| const PEER_POD_CONFIG_PATH: &str = "/run/peerpod/daemon.json"; | ||
| pub const DEFAULT_AA_CONFIG_PATH: &str = "/etc/attestation.toml"; |
There was a problem hiding this comment.
Maybe attestation-agent.toml?
Also there are some interesting tradeoffs. There was once a discussion with @danmihai1 , he suggested to use JSONs for readibility in initdata. I prefer TOML as we can add comments but JSONs cannot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.