Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI and ttrpc built proto files #411

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

Xynnn007
Copy link
Member

@Xynnn007 Xynnn007 commented Dec 15, 2023

  1. Some dependency updates would make the build cannot work. Thus we need to trigger the ci when Cargo.lock changes. Cargo.lock has the information of the dependency versions. This would help to review PRs.
  2. We are now using rust-protobuf 3.3.0 and ttrpc-compiler 0.6.2 to build ttrpc proto files.
  3. Rollback openssl-src to make csv make-able.

Some dependency updates would make the build cannot work. Thus we need
to trigger the ci when Cargo.lock changes. Cargo.lock has the
information of the dependency versions. This would help to review PRs.

Signed-off-by: Xynnn007 <[email protected]>
We are now using rust-protobuf 3.3.0 and ttrpc-compiler 0.6.2 to build
ttrpc proto files.

Signed-off-by: Xynnn007 <[email protected]>
`csv` dep cannot be built using the newest openssl-src dep.

Signed-off-by: Xynnn007 <[email protected]>
Copy link
Member

@arronwy arronwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Xynnn007 LGTM!

@arronwy arronwy merged commit 8a75340 into confidential-containers:main Dec 15, 2023
17 checks passed
@Xynnn007 Xynnn007 deleted the ci-check-lock branch December 15, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants