image-rs: fix image layer ordering #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkulke
requested review from
sameo,
jiangliu,
arronwy,
lumjjb,
jialez0 and
Xynnn007
as code owners
mkulke
force-pushed
the
mkulke/fix-layer-ordering
branch
4 times, most recently
from
5af99aa
to
f25bc21
Compare
When using concurrent pull the resulting order of layers can vary from what's specified in the `rootfs.diff_id` of the oci image config. Layers might be mounted in the wrong order and containers are not able to run properly (e.g. `library/nginx`). Signed-off-by: Magnus Kulke <[email protected]>
mkulke
force-pushed
the
mkulke/fix-layer-ordering
branch
from
f25bc21
to
0cb2cc4
Compare
jialez0
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #403
When using concurrent pull the resulting order of layers can vary from what's specified in the
rootfs.diff_idof the oci image config. Layers might be mounted in the wrong order and containers are not able to run properly (e.g.library/nginx).The change maintains the order of the provided
layer_descsin the resultingVec<LayerMeta>and thus the layers are mounted in the proper order.It has been manually tested w/ 50+ coco containers. The provided test here is disabled by default, because we'll run into rate-limits w/ dockerhub and since it's a race condition it's not guaranteed to fail, either.