Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

Dockerfile: fix rvps dockerfile #162

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

Xynnn007
Copy link
Member

Close confidential-containers/trustee#178

We might cut a v0.8.1 release for RVPS based on this PR.

cc @niteeshkd @mythi @fidencio

Copy link

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I also have this fix in use locally

@Xynnn007
Copy link
Member Author

Hi @fidencio Does this look good to you? After merging this, we will cut a release for AS v0.8.1 to trigger CI to build images.

We do not need to cut KBS v0.8.1 as the current KBS image v0.8.0 ghcr.io/confidential-containers/key-broker-service:built-in-as-v0.8.0 can be run normally

root@406ccd20c384:/# kbs --config-file config.toml 
[2023-11-15T05:12:55Z INFO  kbs] Using config file config.toml
[2023-11-15T05:12:55Z WARN  kbs] insecure APIs are enabled
[2023-11-15T05:12:55Z INFO  api_server] Starting HTTP server at [127.0.0.1:8080]
[2023-11-15T05:12:55Z INFO  actix_server::builder] starting 8 workers
[2023-11-15T05:12:55Z INFO  actix_server::server] Tokio runtime found; starting in existing Tokio runtime

Then we will archive AS repo.

cc @fitzthum

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Xynnn007!

@fidencio fidencio merged commit 158bb06 into confidential-containers:main Nov 16, 2023
3 checks passed
@Xynnn007 Xynnn007 deleted the fix-rvps-docker branch November 16, 2023 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rvps docker image reports missing GLIBC_2.32, GLIBC_2.33, GLIBC_2.34.
3 participants