-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transitive subpackage dependency resolution #5603
Conversation
CodSpeed Performance ReportMerging #5603 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to read in more detail, but should we add a specific test for which transitive deps get picked up into the envs?
Right now the tests only ensure that the recipe from the issue builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks correct, but I am fuzzy on the various m.is_cross
branches. We should a test that specifically looks at the resolved envs for the recipe to ensure it has the right packages.
I'm not sure what you mean here. The test that I added fails to build with the current main branch. |
What I mean is that in the original issue, the output of conda render was shown. This demonstrated that the various envs made during the build did not have the right packages in them. I am saying that in addition to ensuring the recipe from the issue builds, we should explicitly verify that the envs made during the build have the correct transitive packages in them. This will help future maintainers debug any test failures. |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
I am not sure this is relevant, but in rattler-build we actually create variants for each |
That's a different issue. Or rather the second comment in the same issue. See #3308 (comment) |
Description
Checklist - did you ...
news
directory (using the template) for the next release's release notes?Fixes #3308