Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "canceled" build status #438

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gabalafou
Copy link
Contributor

@gabalafou gabalafou commented Oct 22, 2024

Description

This PR is the front-end companion to the following server PR:

This pull request:

  • Adds "CANCELED" status to the front end
  • Adds additional status to "Active" build if the build has ended but the status is not "COMPLETED"
    • Rationale: it was weird to me to see a canceled build marked "Active" in the dropdown. Yes, it is the current build, but it's broken and I think this should be a bit more obvious in the UI.

Screenshots

This screenshot shows how a canceled build appears in the UI. Note that this build is not the current build. The dropdown displays "October 22nd, 2024 - 6:19 PM - Canceled." And on the next line we have "Status: Canceled":

This screenshot shows how the current build appears in the dropdown if it was canceled. The line for this build in the dropdown displays "October 22nd, 2024 - 5:36 PM - Active - Canceled":

I want to be clear that I think that this UI is bad. The UI should draw a sharp visual distinction between failed versus successful builds. But the intent of this PR is not to fix the UI, but to at least make it more accurate by reporting a canceled build as canceled rather than "undefined", as Nikita reported.

Pull request checklist

  • Did you test this change locally?
  • [n/a] Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant