Add new colors and define green theme #292
Conversation
steff456
added
type: enhancement 💅🏼
There was a problem hiding this comment.
LGTM - thanks, @steff456!
To confirm, we're only defining the theme here, correct? And, we're yet to update the UI to use this theme? (The UI seems to have hardcoded colours right now). Please feel free to merge if this is accurate. :)
|
Note I have an unfinished review |
Yes! This is the base PR, I will update the use of the theme across the code base as I start implementing the changes for the design system per component |
| main: "#C4C4C4", | ||
| contrastText: white | ||
| }, | ||
| secondary: { | ||
| main: "#7E7E7E" | ||
| main: "#7E7E7E", | ||
| contrastText: white |
There was a problem hiding this comment.
@smeragoel will have to confirm here the exact colours
There was a problem hiding this comment.
This is a blocker for this PR or can we add the colors for the grayscale theme in a follow up PR?
There was a problem hiding this comment.
nope we can merge this and implement this later
| main: "#C4C4C4", | ||
| contrastText: white | ||
| }, | ||
| secondary: { | ||
| main: "#7E7E7E" | ||
| main: "#7E7E7E", | ||
| contrastText: white |
There was a problem hiding this comment.
nope we can merge this and implement this later
trallard
merged commit 9ca3ef4
into
conda-incubator:design-system-implementation
* Add new colors and define green theme * Fix primary button style * Add new colors for roles and fix the shade used previously * update main shade of color * Fix icon buttons behavior and use across the UI * Change name to condaStoreTheme, define more colors and refactor baseTheme * Add rule for component in the baseTheme * ENH - Redefine new themes and colours (#292) * Add new colors and define green theme * Add new colors for roles and fix the shade used previously * Update main shade of color * Change name to condaStoreTheme, define more colors and refactor baseTheme * Set input focus in purple * Adjust all input components to design system using green * Add new style for disabled buttons and hover state * Implement new toggle switch design * Fix border colors across the UI * add missing semicolon to fix linting issues * Add new design to links (#320) * ENH - Add new sidebar design (#331) * Add new style to left sidebar * define react_app_version env variable * Add custom icons, fix typography in link and do style changes from review * Add trailing whitespace to fix lint error --------- Co-authored-by: Christopher Ostrouchov <[email protected]>
Part of #288
Description
This pull request:
Pull request checklist
Additional information
light,main,darkso I picked three shades in the palette, this can be iterated later on another PR if necessaryerror,info,success, etc. Do we want different colors for those roles or should I use the same accent color for all of them? This as well is something we can add in a follow up PR if necessary.