-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deepsearch-toolkit docling-ibm-models docling-parse docling-core mean-average-precision #28091
Conversation
Hi! This is the staged-recipes linter and I found some lint. It looks like some changes were made outside the If these changes are intentional (and you aren't submitting a recipe), please add a File-specific lints and/or hints:
|
Those are needed to package docling and deepsearch-glm but those two will come in different PRs as they are harder to package. |
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11654600025. |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
blocked by #28092 |
I am seeing error related to missing I can see
Sorry for the ping @beckermr but since you are the author of the various CEFP25 PRs, you might want to be aware of this. Or maybe it's due to rattler-build? |
Hi! This is the staged-recipes linter and I found some lint. It looks like some changes were made outside the If these changes are intentional (and you aren't submitting a recipe), please add a File-specific lints and/or hints:
|
I am taking a look. |
Note that the builds will fail anyway cuz of missing #28092. |
the variable python_min is in the pinnings and rattler-build says it is loading it. I'd say unless we can reproduce with conda-build, this is a rattler bug. |
I can reproduce this minimally indeed:
context:
name: mean-average-precision
version: 2024.01.05.0
package:
name: ${{ name|lower }}
version: ${{ version }}
build:
script: echo ${{ python_min }}
requirements:
host:
- python ${{ python_min }}.*
run:
- python >=${{ python_min }}
python_min:
# minimum supported python version per CFEP-25
# bump to next minor version when we drop python versions
- '3.9'
❯ rattler-build build -m config.yaml -r recipe.yaml --render-only --output-dir /tmp/rattler_output
Error: × Failed to parse recipe
Error: × Parsing: failed to parse match spec: Unable to parse version spec: .*
╭─[14:7]
13 │ host:
14 │ - python ${{ python_min }}.*
· ─────────────┬────────────
· ╰── error parsing `python .*` as a match spec
15 │ run:
╰────
Error: × Parsing: failed to parse match spec: Unable to parse version spec: >=
╭─[16:7]
15 │ run:
16 │ - python >=${{ python_min }}
· ─────────────┬────────────
· ╰── error parsing `python >=` as a match spec
╰──── @wolfv is there is something obvious I am missing here or should I report this as a bug on the rattler-build repo? |
Yeah that's unfortunately a bug that we have to fix. I have made some preliminary work in prefix-dev/rattler-build#1122 that better splits the two rendering phases:
|
Ok. Thanks for the input. I will hard-code it for now, waiting for rattler-build to support it. |
@conda-forge/help-python @conda-forge/help-python-c ready for review.
@beckermr pinging you as you might want to be aware about the |
Thanks for the bump. I will fix. |
@conda-forge/help-python @conda-forge/help-python-c, ready for review. This is blocking for #28093 The windows' failure is due to missing pytorch. |
@conda-forge/help-python @conda-forge/help-python-c, let me know if you prefer to break down this PR into smaller ones. |
Thank you @beckermr ! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).