#328 + remove `TH_BINARY_BUILD` #331

mgorny · 2025-01-25T06:31:06Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

Same as #328, plus remove TH_BINARY_BUILD to see if CI passes.

Fixes conda-forge#319 Fixes conda-forge#320 Fixes conda-forge#321

…nda-forge-pinning 2025.01.20.14.49.21

a successful copy operation may either turn 1, 3, 5 or 7, see https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/robocopy#exit-return-codes and given how atrocious boolean comparisions are in batch (no && or ||, much less set inclusions), just avoid it; c.f. also https://superuser.com/a/280434

Co-authored-by: h-vetinari <[email protected]>

…olidate lib testing

Include Python in build env also when building natively. Otherwise, we end up with Python 3.13 in build env and Python files are byte-compiled for both target Python and 3.13.

This reverts commit 3ebf1a9.

…nda-forge-pinning 2025.01.23.20.59.37

This reverts commit fc5693c.

Fixes conda-forge#330

This patch was only needed because of `TH_BINARY_BUILD`.

…nda-forge-pinning 2025.01.24.17.08.54

conda-forge-admin · 2025-01-25T06:32:24Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12962634810. Examine the logs at this URL for more detail.}

h-vetinari

Glad that you now can trigger jobs yourself! 🥳

h-vetinari · 2025-01-25T06:56:33Z

recipe/meta.yaml

-    # conda-specific patch, upstream force-disables libcufile w/ TH_BINARY_BUILD
-    # for their PyPI wheel builds
-    - patches/0008-Allow-libcufile-for-conda-builds.patch


For a simple removal, regenerating the patches isn't strictly necessary - it'll happen soon enough again anyway (i.e. with the next version). No change necessary, just noting that for future reference.

recipe/patches/0001-Force-usage-of-python-3-and-error-without-numpy.patch

mgorny · 2025-01-26T02:39:41Z

Thanks!

mgorny and others added 30 commits January 19, 2025 15:09

Attempt reenabling cuDSS, cuSPARSELt and CUPTI on Windows

c3b2a1f

Fixes conda-forge#319 Fixes conda-forge#320 Fixes conda-forge#321

Bump build number

673dd87

Skip non-Windows builds

9008ca4

Remove osx-64 code from bld.bat

d241483

Remove py3.8 code from bld.bat

62d4cbd

Add error handling to bld.bat

f8fa30a

Call clean only if build exists

8eb627d

Use a consistent comment style in bld.bat

7f0e31d

Move libraries & co. to %LIBRARY_PREFIX% and subdirs

8e3e4c1

MNT: Re-rendered with conda-build 25.1.1, conda-smithy 3.45.3, and co…

8e3c175

…nda-forge-pinning 2025.01.20.14.49.21

Move torch_python as well

f8375c3

trigger

776ef15

fix robocopy syntax

1eb3609

syntax fixes

afa02aa

remove superfluous errorlevel checks and remove unused label

f21264d

use backslashes for windows paths

3fb0821

Apply suggestions from code review

9b3c70f

Co-authored-by: h-vetinari <[email protected]>

Add a test for TorchConfig.cmake being installed

0674c17

Copy torch_python.lib back to site-packages

855f15c

align indentation

c142c1e

Fix copying libtorch_python.*

5887413

remove skips

cb1bef2

copy first, delete later

1ce4bd8

more robocopy syntax fixes

7b18054

move _C.lib back to site-packages

a8d4380

do not package fmt.lib in libtorch

a239392

pin python in build environment to same version as in host

fc5693c

DEBUG: build only one python version

3ebf1a9

also delete fmt metadata

7a1e86b

h-vetinari and others added 14 commits January 22, 2025 23:06

only move torch* libraries into %LIBRARY_{BIN,LIB}%

67a8fc5

Update tests to match new list of installed libs

eb8dc6f

move c10/smh to %LIBRARY_PREFIX% as on unix; also asmjit/fbgemm; cons…

851aae4

…olidate lib testing

adapt the way pytorch constructs include paths to $PREFIX/include

e0e34e3

Match Python in build env

c26c87a

Include Python in build env also when building natively. Otherwise, we end up with Python 3.13 in build env and Python files are byte-compiled for both target Python and 3.13.

fix handling of CUDA libraries on windows

6355886

add regression test for duplicate .pyc files

6c7d83f

Revert "DEBUG: build only one python version"

eb3c6d0

This reverts commit 3ebf1a9.

Merge remote-tracking branch 'upstream/main' into more-win

92b4f30

MNT: Re-rendered with conda-build 25.1.1, conda-smithy 3.45.3, and co…

1c1ac05

…nda-forge-pinning 2025.01.23.20.59.37

Revert "pin python in build environment to same version as in host"

1c3a925

This reverts commit fc5693c.

Remove TH_BINARY_BUILD

e067df1

Fixes conda-forge#330

Remove no-longer-needed libcufile build patch

6fb1a3e

This patch was only needed because of `TH_BINARY_BUILD`.

MNT: Re-rendered with conda-build 25.1.1, conda-smithy 3.45.4, and co…

b3b972f

…nda-forge-pinning 2025.01.24.17.08.54

mgorny requested review from Tobias-Fischer, baszalmstra, beckermr, benjaminrwilson, h-vetinari, hmaarrfk, jeongseok-meta and sodre as code owners January 25, 2025 06:31

h-vetinari reviewed Jan 25, 2025

View reviewed changes

h-vetinari mentioned this pull request Jan 25, 2025

Move libtorch bits to PREFIX & enable cuDSS, cuSPARSELt, CUPTI on win; fix duplicate .pyc versions #328

Merged

5 tasks

h-vetinari merged commit b3b972f into conda-forge:main Jan 25, 2025
27 checks passed

h-vetinari added a commit that referenced this pull request Jan 25, 2025

Merge pull request #331 from mgorny/more-win-and-thbinbu

dfadf15

h-vetinari mentioned this pull request Jan 25, 2025

Sync some features with anaconda's recipe #318

Merged

5 tasks

mgorny deleted the more-win-and-thbinbu branch January 26, 2025 02:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#328 + remove `TH_BINARY_BUILD` #331

#328 + remove `TH_BINARY_BUILD` #331

mgorny commented Jan 25, 2025 •

edited

Loading

conda-forge-admin commented Jan 25, 2025

h-vetinari left a comment

h-vetinari Jan 25, 2025

mgorny commented Jan 26, 2025

#328 + remove TH_BINARY_BUILD #331

#328 + remove TH_BINARY_BUILD #331

Conversation

mgorny commented Jan 25, 2025 • edited Loading

conda-forge-admin commented Jan 25, 2025

h-vetinari left a comment

Choose a reason for hiding this comment

h-vetinari Jan 25, 2025

Choose a reason for hiding this comment

mgorny commented Jan 26, 2025

#328 + remove `TH_BINARY_BUILD` #331

#328 + remove `TH_BINARY_BUILD` #331

mgorny commented Jan 25, 2025 •

edited

Loading