Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the underline happening on logo #2373

Closed
wants to merge 3 commits into from
Closed

fix: remove the underline happening on logo #2373

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9827d16
fix:underline on icons
TenzDelek Nov 16, 2024
9a3dea3
updates
TenzDelek Nov 16, 2024
79a653f
mobile view fix
TenzDelek Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 16 additions & 40 deletions src/css/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

/* You can override the default Infima variables here. */

@font-face {
@font-face {
font-family: "Inter";
src: url("/fonts/Inter-VariableFont_opsz,wght.ttf"),
url("/fonts/Inter-Italic-VariableFont_opsz,wght.ttf");
Expand Down Expand Up @@ -104,51 +104,27 @@ a {
text-decoration-thickness: var(--pydata-link-underline-thickness);
text-underline-offset: var(--pydata-link-underline-offset);
}

a:hover,
/* We need to (re)override some of the infima rules to have proper states on
navbar links, table of contents, and docs sidebar links, respectively */
a.navbar__link:hover, /* Top bar navigation links */
a.table-of-contents__link:hover, /*Right sidebar links (table of contents) */
a[class^="sidebarItemLink"]:hover /* The docs sidebar links do not have its own class */ {
/* Base link styles */
.navbar__link {
text-decoration: none;
}
.navbar__link:hover {
text-decoration: underline;
text-decoration-thickness: var(--pydata-link-hover-decoration-thickness);
text-decoration-skip-ink: none;
text-decoration-skip: none;
}
a:active,
a.navbar__link:active,
a.table-of-contents__link:active,
a[class^="sidebarItemLink"]:active {
text-decoration-thickness: var(--pydata-link-decoration-thickness);
text-underline-offset: var(--pydata-link-underline-offset);
}

/* In some cases, we override the underlines because there are other elements that
already report the state (e.g. borders, background colors, etc) */
a[class^="sidebarItemLink"][aria-current="page"], /* No underline if this is the current page */
a.navbar__link,
.navbar-sidebar__item,
.menu a,
.navbar__items--right a,
.pagination-nav__link,
a.card, /* These cards are used in index-like documentation pages */
a.card:hover {
text-decoration: none;
/* Remove underlines from GitHub and Zulip icons in both desktop and mobile views */
.navbar__items--right a[class*="fa-"],
.navbar-sidebar__items a[class*="fa-"] {
text-decoration: none !important;
}

/* On these elements, we only rely on background color changes. They are navigation items,
so they are already assumed to be clickable anyway */
.pagination-nav__link:active,
a.card:active,
a.menu__link:active {
background: var(--ifm-color-primary-lightest);
color: #000;
}
[data-theme="dark"] .pagination-nav__link:active,
[data-theme="dark"] a.card:active,
[data-theme="dark"] a.menu__link:active {
background: var(--ifm-color-primary-darkest);
color: #fff;
.navbar__items--right a[class*="fa-"]:hover,
.navbar-sidebar__items a[class*="fa-"]:hover {
text-decoration: none !important;
opacity: 0.7;
transition: opacity 0.2s ease-in-out;
}

/* Animate the top navbar conda-forge logo a bit */
Expand Down