Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bipedal-locomotion-framework v0.13.0 #25

Merged
merged 4 commits into from
Apr 28, 2023

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
bipedal-locomotion-framework 0.13.0 Anaconda-Server Badge
casadi 3104 Anaconda-Server Badge
pip 23.1.1 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • lxml
  • yarp-python
  • arm_pyart
  • pyyaml

Packages found in the meta.yaml but not found by source code inspection:

  • manif
  • libbipedal-locomotion-framework

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/4772401898, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@GiulioRomualdi GiulioRomualdi added the automerge Merge the PR when CI passes label Apr 22, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@traversaro
Copy link
Contributor

traversaro commented Apr 26, 2023

On Linux all python tests are failing with error:

E   ImportError: generic_type: cannot initialize type "Verbosity": an object with that name is already defined

While on macOS/Windows:

================================== FAILURES ===================================
__________________________ test_fixed_foot_detector ___________________________

    def test_fixed_foot_detector():
        dt = 0.01
    
        parameters_handler = blf.parameters_handler.StdParametersHandler()
        parameters_handler.set_parameter_float("sampling_time", dt)
    
        detector = blf.contacts.FixedFootDetector()
>       assert (detector.initialize(parameters_handler))
E       assert False
E        +  where False = <bound method PyCapsule.initialize of <bipedal_locomotion_framework.bindings.contacts.FixedFootDetector object at 0x0000028E451C8DF0>>(sampling_time )
E        +    where <bound method PyCapsule.initialize of <bipedal_locomotion_framework.bindings.contacts.FixedFootDetector object at 0x0000028E451C8DF0>> = <bipedal_locomotion_framework.bindings.contacts.FixedFootDetector object at 0x0000028E451C8DF0>.initialize

python\Contacts\tests\test_fixed_foot_detector.py:17: AssertionError
---------------------------- Captured stdout call -----------------------------
[2023-04-22 12:18:13.377] [thread: 6540] [blf] [error] [FixedFootDetector::customInitialization] Unable to find the 'sampling_time' parameter.


@traversaro traversaro closed this Apr 26, 2023
@traversaro traversaro reopened this Apr 26, 2023
@traversaro
Copy link
Contributor

It turns out that the Python bindings were not running upstream, see ami-iit/bipedal-locomotion-framework#657 . Let's see if the failures are also there.

@traversaro
Copy link
Contributor

traversaro commented Apr 27, 2023

Actually the linux test also fails with:

2023-04-26T17:52:15.7380592Z ../../_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.11/site-packages/bipedal_locomotion_framework/__init__.py:1: in <module>
2023-04-26T17:52:15.7381035Z     from .bindings import *
2023-04-26T17:52:15.7381686Z E   ImportError: arg(): could not convert default argument 'mixed_velocity: manif::SE3Tangent<double>' in method '<class 'bipedal_locomotion_framework.bindings.ik.SE3Task'>.set_set_point' into a Python object (type not registered yet?)

And actually the compiler version is updated, so the issue could be the usual conda-forge/pybind11-feedstock#77, ami-iit/bipedal-locomotion-framework#386, conda-forge/manif-feedstock#19 and similar.

@traversaro
Copy link
Contributor

Ok, with the manifpy rebuild we were able to get rid of the complete testsuite failure on Linux, now also linux fails with:

2023-04-27T14:28:19.7388642Z =================================== FAILURES ===================================
2023-04-27T14:28:19.7389233Z ___________________________ test_fixed_foot_detector ___________________________
2023-04-27T14:28:19.7389450Z 
2023-04-27T14:28:19.7389702Z     def test_fixed_foot_detector():
2023-04-27T14:28:19.7389956Z         dt = 0.01
2023-04-27T14:28:19.7390196Z     
2023-04-27T14:28:19.7390515Z         parameters_handler = blf.parameters_handler.StdParametersHandler()
2023-04-27T14:28:19.7390849Z         parameters_handler.set_parameter_float("sampling_time", dt)
2023-04-27T14:28:19.7391113Z     
2023-04-27T14:28:19.7391373Z         detector = blf.contacts.FixedFootDetector()
2023-04-27T14:28:19.7391663Z >       assert (detector.initialize(parameters_handler))
2023-04-27T14:28:19.7391943Z E       assert False
2023-04-27T14:28:19.7392305Z E        +  where False = <bound method PyCapsule.initialize of <bipedal_locomotion_framework.bindings.contacts.FixedFootDetector object at 0x7fe27ec89ef0>>(sampling_time )
2023-04-27T14:28:19.7392875Z E        +    where <bound method PyCapsule.initialize of <bipedal_locomotion_framework.bindings.contacts.FixedFootDetector object at 0x7fe27ec89ef0>> = <bipedal_locomotion_framework.bindings.contacts.FixedFootDetector object at 0x7fe27ec89ef0>.initialize
2023-04-27T14:28:19.7393254Z 
2023-04-27T14:28:19.7393535Z python/Contacts/tests/test_fixed_foot_detector.py:17: AssertionError
2023-04-27T14:28:19.7394166Z ----------------------------- Captured stderr call -----------------------------
2023-04-27T14:28:19.7394762Z [ERROR] [2023-04-27 14:28:15.350] [thread: 3718] [blf] [FixedFootDetector::customInitialization] Unable to find the 'sampling_time' parameter.

@traversaro
Copy link
Contributor

Ok, with the manifpy rebuild we were able to get rid of the complete testsuite failure on Linux, now also linux fails with:

2023-04-27T14:28:19.7388642Z =================================== FAILURES ===================================
2023-04-27T14:28:19.7389233Z ___________________________ test_fixed_foot_detector ___________________________
2023-04-27T14:28:19.7389450Z 
2023-04-27T14:28:19.7389702Z     def test_fixed_foot_detector():
2023-04-27T14:28:19.7389956Z         dt = 0.01
2023-04-27T14:28:19.7390196Z     
2023-04-27T14:28:19.7390515Z         parameters_handler = blf.parameters_handler.StdParametersHandler()
2023-04-27T14:28:19.7390849Z         parameters_handler.set_parameter_float("sampling_time", dt)
2023-04-27T14:28:19.7391113Z     
2023-04-27T14:28:19.7391373Z         detector = blf.contacts.FixedFootDetector()
2023-04-27T14:28:19.7391663Z >       assert (detector.initialize(parameters_handler))
2023-04-27T14:28:19.7391943Z E       assert False
2023-04-27T14:28:19.7392305Z E        +  where False = <bound method PyCapsule.initialize of <bipedal_locomotion_framework.bindings.contacts.FixedFootDetector object at 0x7fe27ec89ef0>>(sampling_time )
2023-04-27T14:28:19.7392875Z E        +    where <bound method PyCapsule.initialize of <bipedal_locomotion_framework.bindings.contacts.FixedFootDetector object at 0x7fe27ec89ef0>> = <bipedal_locomotion_framework.bindings.contacts.FixedFootDetector object at 0x7fe27ec89ef0>.initialize
2023-04-27T14:28:19.7393254Z 
2023-04-27T14:28:19.7393535Z python/Contacts/tests/test_fixed_foot_detector.py:17: AssertionError
2023-04-27T14:28:19.7394166Z ----------------------------- Captured stderr call -----------------------------
2023-04-27T14:28:19.7394762Z [ERROR] [2023-04-27 14:28:15.350] [thread: 3718] [blf] [FixedFootDetector::customInitialization] Unable to find the 'sampling_time' parameter.

This turned out to be a test that was not updated with the latest changes in API in ami-iit/bipedal-locomotion-framework#630, and that was accidentally not run in the upstream CI: ami-iit/bipedal-locomotion-framework#658 .

@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Apr 27, 2023
@traversaro
Copy link
Contributor

As the bug is just in the test, I just disabled it in the CI.

@traversaro
Copy link
Contributor

Ok, we are good to go!

@traversaro traversaro merged commit 59b3960 into conda-forge:main Apr 28, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.13.0_h9653c5 branch April 28, 2023 08:02
@traversaro traversaro mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants