Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Toast Renderer #6613

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

seanparsons
Copy link
Contributor

Problem:
Toasts aren't displaying.

Fix:
The ToastRenderer has been re-added into the editor hierarchy.

Commit Details:

  • Readded ToastRenderer to CanvasFloatingToolbars.

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

- Readded `ToastRenderer` to `CanvasFloatingToolbars`.
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Try me

Copy link

relativeci bot commented Nov 1, 2024

#14998 Bundle Size — 58.04MiB (~+0.01%).

933bccd(current) vs d1d46c1 master#14994(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14998
     Baseline
#14994
Regression  Initial JS 41.02MiB(~+0.01%) 41.02MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.08% 17.96%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4165 4165
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.31% 27.31%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14998
     Baseline
#14994
Regression  JS 58.03MiB (~+0.01%) 58.03MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch fix/restore-toast-rendererProject dashboard


Generated by RelativeCIDocumentationReport issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants