New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(import): design review #6611

Draft

liady wants to merge 4 commits into master from fix/import-design-review

Contributor

liady commented Oct 31, 2024 •

edited

Loading

Design fixes according to Mckayla's review

Manual Tests:
I hereby swear that:

I opened a hydrogen project and it loaded
I could navigate to various routes in Play mode

liady added 4 commits

October 31, 2024 16:42


          fix(import): design review

084c4f8


          Merge branch 'master' into fix/import-design-review

8a08b81


          color

50f74ba


          color

f748e9d

Contributor

github-actions bot commented Oct 31, 2024 •

edited

Loading

Try me

relativeci bot commented Oct 31, 2024

#14988 Bundle Size — 58.03MiB (~-0.01%).

f748e9d(current) vs d1d46c1 master#14984(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics

Change

2 changes

Improvement

1 improvement

	Current #14988	Baseline #14984
Initial JS	`41.01MiB`(`~-0.01%`)	`41.01MiB`
Initial CSS	`0B`	`0B`
Cache Invalidation	`18.07%`	`17.95%`
Chunks	`20`	`20`
Assets	`22`	`22`
Modules	`4164`	`4164`
Duplicate Modules	`213`	`213`
Duplicate Code	`27.32%`	`27.32%`
Packages	`477`	`477`
Duplicate Packages	`70`	`70`

Bundle size by type

Change

2 changes

Improvement

2 improvements

	Current #14988	Baseline #14984
JS	`58.02MiB` (`~-0.01%`)	`58.02MiB`
HTML	`7.37KiB` (`-0.25%`)	`7.39KiB`

Bundle analysis report Branch fix/import-design-review Project dashboard

^{Generated by RelativeCI Documentation Report issue}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet