Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(import): early break on error #6604

Merged
merged 1 commit into from
Oct 31, 2024
Merged

feat(import): early break on error #6604

merged 1 commit into from
Oct 31, 2024

Conversation

liady
Copy link
Contributor

@liady liady commented Oct 30, 2024

This PR breaks early when there is a requirement check error (for example a TS project) - without fetching dependencies or dispatching the results to the project.
For example a Next TS project - note the dependencies are not fetched and the project contents are not updated:

Monosnap.screencast.2024-10-30.18-48-14.mp4

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Try me

Copy link

relativeci bot commented Oct 30, 2024

#14971 Bundle Size — 58.03MiB (~+0.01%).

293593e(current) vs d1d46c1 master#14966(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14971
     Baseline
#14966
Regression  Initial JS 41.01MiB(~+0.01%) 41.01MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.06% 17.95%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4163 4163
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.31% 27.31%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14971
     Baseline
#14966
Regression  JS 58.02MiB (~+0.01%) 58.02MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch feat/early-break-on-errorProject dashboard


Generated by RelativeCIDocumentationReport issue

@liady liady merged commit 36213b9 into master Oct 31, 2024
16 checks passed
@liady liady deleted the feat/early-break-on-error branch October 31, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants