feat(import): check for server dependencies #6603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#14972 Bundle Size — 58.03MiB (~+0.01%).9ff3903(current) vs d1d46c1 master#14966(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14972 |
Baseline #14966 |
|
|---|---|---|
 Initial JS |
41.01MiB(~+0.01%) |
41.01MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.06% |
17.95% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4164(+0.02%) |
4163 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.32%(+0.04%) |
27.31% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #14972 |
Baseline #14966 |
|
|---|---|---|
| JS |
58.02MiB (~+0.01%) |
58.02MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch feat/check-server-dependencies Project dashboard
Generated by RelativeCI Documentation Report issue
liady
requested review from
gbalint,
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics and
bkrmendy
liady
commented
Oct 31, 2024
| @@ -761,3 +761,36 @@ export function ensureDirectoriesExist(projectContents: ProjectContents): Projec | |||
| return result | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
these were just moved here as-is from check-utopia-requiremenets.ts
Rheeseyb
reviewed
Oct 31, 2024
editor/src/core/shared/import/proejct-health-check/requirements/requirement-server-packages.ts
Show resolved
Hide resolved
Rheeseyb
approved these changes
Oct 31, 2024
bkrmendy
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note for reviewers:
Other than refactors, tests and name changes, the actual logic is only in requirement-server-packages.ts.
(I had to change the resolution name from
'Found'to'Passed'since here a passing check means that server packages weren't actually found)PR details:
This PR adds a check for server dependencies to the import process - currently a very closed list, to be added more incrementally.
For example when importing a Next project:
Monosnap.screencast.2024-10-30.18-30-51.mp4
Manual Tests:
I hereby swear that: