A Less Aggressive Auto-Collapse #6598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6aeac40.
#14992 Bundle Size — 58.04MiB (~+0.01%).c3ea885(current) vs d1d46c1 master#14991(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14992 |
Baseline #14991 |
|
|---|---|---|
 Initial JS |
41.01MiB(~+0.01%) |
41.01MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.07% |
17.95% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4165(+0.02%) |
4164 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.31% |
27.31% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #14992 |
Baseline #14991 |
|
|---|---|---|
| JS |
58.03MiB (~+0.01%) |
58.03MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch fix/autocollapse Project dashboard
Generated by RelativeCI Documentation Report issue
- Moved `getHuggingElementContentsStatus` into its own file and extracted out the type `HuggingElementContentsStatus`. - Changed type of `PushIntendedBoundsAndUpdateHuggingElements.value`. - Added additional escape case in `applyUpdateResizeHuggingElementsCommands`. - `deleteElements` stores some more values upfront in the `trueUpHuggingElement` value. - Added `elementFrame` and `huggingElementContentsStatus` to `TrueUpHuggingElement`.
seanparsons
changed the title
seanparsons
requested review from
gbalint,
Rheeseyb,
ruggi,
liady and
bkrmendy
ruggi
approved these changes
Oct 31, 2024
...r/src/components/canvas/commands/push-intended-bounds-and-update-hugging-elements-command.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We want a slightly more refined auto-collapse behaviour.
Fix:
The previous behaviour has been re-enabled with an additional check. The additional check is supported with data passed through from before any changes have been made to the element, so that it's possible to identify the change in situation.
Commit Details:
pushIntendedBoundsAndUpdateHuggingElementsalong with the changes from that PR.getHuggingElementContentsStatusinto its own file andextracted out the type
HuggingElementContentsStatus.PushIntendedBoundsAndUpdateHuggingElements.value.applyUpdateResizeHuggingElementsCommands.deleteElementsstores some more values upfront in thetrueUpHuggingElementvalue.
elementFrameandhuggingElementContentsStatustoTrueUpHuggingElement.